Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Adding Models for General Use documentation #1019

Merged
merged 2 commits into from
May 8, 2023
Merged

Cleaned up Adding Models for General Use documentation #1019

merged 2 commits into from
May 8, 2023

Conversation

antoninkriz
Copy link
Contributor

Minor cleanup of some mistakes in the documentation I stumbled upon when implementing a new model

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Much appreciated.

Let me know if you need further guidance implementing your interface.

@ablaom
Copy link
Member

ablaom commented May 8, 2023

@antoninkriz Do you mind rebasing your PR so as to make dev branch the target?

@antoninkriz antoninkriz changed the base branch from master to dev May 8, 2023 11:52
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #1019 (9467c98) into dev (ec999a1) will not change coverage.
The diff coverage is n/a.

❗ Current head 9467c98 differs from pull request most recent head a826318. Consider uploading reports for the commit a826318 to get more accurate results

@@           Coverage Diff           @@
##              dev    #1019   +/-   ##
=======================================
  Coverage   42.85%   42.85%           
=======================================
  Files           1        1           
  Lines          28       28           
=======================================
  Hits           12       12           
  Misses         16       16           

@antoninkriz
Copy link
Contributor Author

@ablaom Done, thank you!
The master branch was a missclick, I shoud've noticed it sooner.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again

@ablaom ablaom merged commit 66ad99f into JuliaAI:dev May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants