Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #1020

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.32,0.33 to 0.32,0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ablaom ablaom force-pushed the compathelper/new_version/2023-05-02-00-20-21-602-02753218924 branch from ab4c054 to 23423de Compare May 2, 2023 00:20
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #1020 (23423de) into dev (ec999a1) will increase coverage by 18.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev    #1020       +/-   ##
===========================================
+ Coverage   42.85%   60.97%   +18.11%     
===========================================
  Files           1        2        +1     
  Lines          28       41       +13     
===========================================
+ Hits           12       25       +13     
  Misses         16       16               

see 1 file with indirect coverage changes

@ablaom ablaom closed this May 16, 2023
@ablaom ablaom reopened this May 16, 2023
@ablaom
Copy link
Member

ablaom commented May 16, 2023

See #1022 for what is still needed here.

@ablaom ablaom closed this Jun 15, 2023
@ablaom ablaom reopened this Jun 15, 2023
@ablaom ablaom merged commit a764cd8 into dev Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants