Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of LossFunctions.jl #919

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Bump version of LossFunctions.jl #919

merged 1 commit into from
Jul 30, 2023

Conversation

juliohm
Copy link
Contributor

@juliohm juliohm commented Jul 30, 2023

This version bump just introduces a new submodule for namespace hygiene. Now users of LossFunctions.jl need to import LossFunctions.Traits to get the trait functions and abstract types.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Merging #919 (de9b8a7) into dev (fa009a1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #919   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          40       40           
  Lines        3653     3653           
=======================================
  Hits         3206     3206           
  Misses        447      447           
Files Changed Coverage Δ
src/MLJBase.jl 100.00% <ø> (ø)

@juliohm
Copy link
Contributor Author

juliohm commented Jul 30, 2023

ping @ablaom @OkonSamuel

@DilumAluthge DilumAluthge requested a review from ablaom July 30, 2023 00:40
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliohm Thanks for this PR. Appreciate it.

@ablaom ablaom merged commit 6715bfd into JuliaAI:dev Jul 30, 2023
3 checks passed
@juliohm
Copy link
Contributor Author

juliohm commented Jul 31, 2023

Thank you for merging @ablaom, appreciate if you can trigger a patch release so that we can continue some updates downstream.

@OkonSamuel OkonSamuel mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants