Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses JuliaAI/MLJ.jl#693 .
@load
is not changed by this PR with this exception: By defaultverbosity=1
, so that newcomers understand what the macros is doing. I think this has been a source of confusion a number of times.to load code without returning an instance of the new model type, there is a new macro
@loadcode
Support for the
load
function is removed. Instead, for explicit importing of model types without a macro, the user may extract the appropriate load path using theload_path
function, a model trait now overloaded to work on strings and model registry entries:TODO:
@load
works from within modules and packages (provided interface is not Requires-loaded - a known issue, see lazy activation of models not working from within packages #22)