Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "MLJModelInterface" to "1.0" #39

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the MLJModelInterface package from ^0.3.5, ^0.4 to ^0.3.5, ^0.4, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ablaom ablaom closed this Apr 20, 2021
@ablaom ablaom reopened this Apr 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #39 (25d25d4) into dev (d8923c9) will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #39      +/-   ##
==========================================
+ Coverage   91.30%   92.39%   +1.09%     
==========================================
  Files           4        3       -1     
  Lines         299      342      +43     
==========================================
+ Hits          273      316      +43     
  Misses         26       26              
Impacted Files Coverage Δ
src/utils.jl 100.00% <0.00%> (ø)
src/NearestNeighborModels.jl
src/models.jl 90.38% <0.00%> (+1.09%) ⬆️
src/kernels.jl 90.17% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8923c9...25d25d4. Read the comment docs.

@ablaom ablaom merged commit 40b86a1 into dev Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants