Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERFA Overhaul #35

Merged
merged 20 commits into from
Jan 29, 2018
Merged

ERFA Overhaul #35

merged 20 commits into from
Jan 29, 2018

Conversation

helgee
Copy link
Member

@helgee helgee commented Jan 27, 2018

Okay, I have changed a lot of things. But I split the changes in nice thematic commits...

@helgee
Copy link
Member Author

helgee commented Jan 28, 2018

CI failures are due to this: JuliaPackaging/BinDeps.jl#351

I would like to fix 0.7 deprecations and the above issue as well while I am at it. But without Compat.jl this is cumbersome. Any objections to adding the dependency back? BinDeps.jl installs it anyways.

@helgee
Copy link
Member Author

helgee commented Jan 28, 2018

I tried to add @testset blocks but commented them out again because the performance is currently abysmal, see JuliaLang/julia#18077 (comment)

@giordano
Copy link
Member

I didn't have the time to have a look at this, just wanted to say that I think it's fine to require Compat

@helgee
Copy link
Member Author

helgee commented Jan 28, 2018

CI is green 🎉

giordano
giordano reviewed Jan 29, 2018
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good. Great refactoring work!

src/erfa_common.jl
@@ -1,66 +1,41 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these constants are used nowhere, perhaps are better suited in the newly-born AstroBase.jl package. And DPI and D2PI are probably redundant, given we have pi in Julia. Anyway, this is unrelated to this change.

@helgee
Copy link
Member Author

helgee commented Jan 29, 2018

I will merge this later and tag a new release if I hear no objections.

@helgee helgee merged commit 40fec85 into master Jan 29, 2018
@helgee helgee deleted the erfa-ng branch January 29, 2018 20:37
@giordano giordano mentioned this pull request Jan 30, 2018
Closed
@giordano giordano mentioned this pull request Jan 31, 2018
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helgee @giordano