Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail generating AWSException if resposne_stream is BufferStream #562

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Don't fail generating AWSException if resposne_stream is BufferStream #562

merged 2 commits into from
Jun 28, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jun 21, 2022

No description provided.

@quinnj quinnj mentioned this pull request Jun 21, 2022
Closed
github-actions[bot]
github-actions bot reviewed Jun 21, 2022
View reviewed changes
test/AWS.jl Outdated Show resolved Hide resolved
test/AWS.jl Outdated Show resolved Hide resolved
test/AWS.jl Outdated Show resolved Hide resolved
test/AWS.jl Outdated Show resolved Hide resolved
@mattBrzezinski @github-actions
Apply suggestions from code review
6e02815 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mattBrzezinski
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 22, 2022
@bors
Try #562:
fdb372b
@bors
Copy link
Contributor

bors bot commented Jun 22, 2022

try

Build succeeded:

@iamed2
Copy link
Member

iamed2 commented Jun 28, 2022

bors r+

bors bot added a commit that referenced this pull request Jun 28, 2022
@bors @quinnj @mattBrzezinski
Merge #562
f8225bd 
562: Don't fail generating AWSException if resposne_stream is BufferStream r=iamed2 a=quinnj



Co-authored-by: Jacob Quinn <quinn.jacobd@gmail.com>
Co-authored-by: mattBrzezinski <matt.brzezinski@invenia.ca>
@iamed2 iamed2 mentioned this pull request Jun 28, 2022
Merged
@bors
Copy link
Contributor

bors bot commented Jun 28, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@iamed2
Copy link
Member

iamed2 commented Jun 28, 2022

bors r+

@bors bors bot merged commit 893f0d6 into master Jun 28, 2022
@bors bors bot deleted the jq/bufstm_excp branch June 28, 2022 15:56
@bors
Copy link
Contributor

bors bot commented Jun 28, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@iamed2 iamed2 iamed2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinnj @mattBrzezinski @iamed2