Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat section for dependencies #33

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Add compat section for dependencies #33

merged 4 commits into from
Sep 23, 2020

Conversation

mattBrzezinski
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #33 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #33      +/-   ##
=========================================
- Coverage    8.17%   8.15%   -0.03%     
=========================================
  Files          11      11              
  Lines         379     429      +50     
=========================================
+ Hits           31      35       +4     
- Misses        348     394      +46     
Impacted Files Coverage Δ
src/api/datastore.jl 13.79% <0.00%> (-1.03%) ⬇️
src/session.jl 0.00% <0.00%> (ø)
src/collection.jl 0.00% <0.00%> (ø)
src/credentials.jl 0.00% <0.00%> (ø)
src/api/api.jl 22.13% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4c92c...cc0899a. Read the comment docs.

@mjram0s
Copy link

mjram0s commented Sep 23, 2020

Should probably add compat entries for all dependencies?

@mattBrzezinski
Copy link
Member Author

Should probably add compat entries for all dependencies?

The other deps are Base64, Dates, Markdown, Printf are all part of base Julia AFAIK and do not require compat specifications?

@mjram0s
Copy link

mjram0s commented Sep 23, 2020

Should probably add compat entries for all dependencies?

The other deps are Base64, Dates, Markdown, Printf are all part of base Julia AFAIK and do not require compat specifications?

Oh I missed that. Approved then!

@mattBrzezinski mattBrzezinski merged commit ace686c into master Sep 23, 2020
@omus omus deleted the MB/ci-fix branch September 26, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants