improvements to gangoffour and gofplot #695
Conversation
|
Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions/runs/2526977438?check_suite_focus=true for more details. |
| plots_id = Base.PkgId(UUID("91a5bcdd-55d7-5caf-9e0b-520d859cae80"), "Plots") | ||
| haskey(Base.loaded_modules, plots_id) || error("Call using Plots before calling this function") | ||
| Plots = Base.loaded_modules[plots_id] |
There was a problem hiding this comment.
Nice way to solve the implicit dependency. Just thought that one other nice thing with recipes is that they could technically work with more backends, e.g. Makie, IIUC. Maybe not the main focus for us, so I don't think it should hinder this PR.
There was a problem hiding this comment.
Nvm, just tried and seems Makie does not play with the recipes we have so I guess they have their own recipe system? I was pretty sure I had tried this before and it worked, seems like a miss if they aren't cross compatible with the recipes :/
There was a problem hiding this comment.
makie did have some very basic support for Plots recipes a long time ago, but it got stale and never updated.
There was a problem hiding this comment.
If makie did work with Plots recipes, I'd probably use Makie way more often. Now, there's just too much invested in Plots recipes to bother making the change :P
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 87.51% 87.58% +0.06%
==========================================
Files 35 35
Lines 3597 3601 +4
==========================================
+ Hits 3148 3154 +6
+ Misses 449 447 -2
Continue to review full report at Codecov.
|
Now works for MIMO systems etc.