Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REQUIRE with WeakRefStrings & DataStreams upperbounds for release #94

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Update REQUIRE with WeakRefStrings & DataStreams upperbounds for release #94

merged 1 commit into from
Aug 29, 2017

Conversation

cjprybol
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 26, 2017

Codecov Report

Merging #94 into master will decrease coverage by 18.9%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #94       +/-   ##
===========================================
- Coverage   95.81%   76.91%   -18.91%     
===========================================
  Files           5        5               
  Lines         598      745      +147     
===========================================
  Hits          573      573               
- Misses         25      172      +147
Impacted Files Coverage Δ
src/CSV.jl 64.7% <0%> (-35.3%) ⬇️
src/Sink.jl 67.69% <0%> (-27.96%) ⬇️
src/Source.jl 76.87% <0%> (-23.13%) ⬇️
src/io.jl 77.12% <0%> (-22.04%) ⬇️
src/parsefields.jl 79.87% <0%> (-12.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32941fa...55e0bbc. Read the comment docs.

@cjprybol
Copy link
Contributor Author

holding off on this until JuliaLang/METADATA.jl#10915. If the upper bounds are added as shown in this diff then this won't be necessary. In that case, remember to close JuliaLang/METADATA.jl#10923 too rather than retagging a v0.1.5 release

@nalimilan
Copy link
Member

Adding the bounds here to match those in METADATA.jl would be a good idea. We can easily remove them once the package will support the newer versions.

@cjprybol cjprybol changed the title Update REQUIRE with WeakRefStrings upperbound for final pre-null release Update REQUIRE with WeakRefStrings & DataStreams upperbounds for release Aug 29, 2017
@cjprybol cjprybol merged commit 2c58187 into JuliaData:master Aug 29, 2017
@cjprybol cjprybol deleted the cjp/versioncap branch August 29, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants