Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow isless() on unordered CategoricalValues #58

Merged
merged 2 commits into from
Feb 25, 2017
Merged

Conversation

nalimilan
Copy link
Member

< still raises an error for unordered values to protect from meaningless
comparisons, but isless() is now allowed to support sort() on unordered arrays,
where this operation is useful. This behavior is consistent with e.g. NaN being
sorted last by isless() despite the comparison having no mathematical signification.

Cc: @cjprybol

< still raises an error for unordered values to protect from meaningless
comparisons, but isless() is now allowed to support sort() on unordered arrays,
where this operation is useful. This behavior is consistent with e.g. NaN being
sorted last by isless() despite the comparison having no mathematical signification.
@cjprybol
Copy link
Contributor

Same here, thanks for writing these up!

@coveralls
Copy link

coveralls commented Feb 25, 2017

Coverage Status

Coverage decreased (-0.1%) to 90.744% when pulling 0a1cb4c on nl/isless into 388575a on master.

@codecov-io
Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #58 into master will increase coverage by 0.65%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   90.89%   91.54%   +0.65%     
==========================================
  Files           9        9              
  Lines         494      532      +38     
==========================================
+ Hits          449      487      +38     
  Misses         45       45
Impacted Files Coverage Δ
src/value.jl 74.5% <75%> (+13.9%)
src/array.jl 93.06% <ø> (+0.61%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388575a...9e59866. Read the comment docs.

Also throw a more specific ArgumentError.
@coveralls
Copy link

coveralls commented Feb 25, 2017

Coverage Status

Coverage increased (+0.4%) to 91.304% when pulling 9e59866 on nl/isless into 388575a on master.

@nalimilan nalimilan merged commit a4b9929 into master Feb 25, 2017
@nalimilan nalimilan deleted the nl/isless branch February 25, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants