poolset: Add optional destructor function #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/chained-dtor
branch
from
809c6de
to
933f869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemPool's usage of distributed refcounting and GC finalizers causes slightly excessive memory retention, because it takes sometimes some extra time or an extra GC cycle to clean up data that's been
poolsetonce allDRefs are freed.This PR adds an optional user-defined "destructor" callback, which is invoked when an object that's been
poolsetbecomes no longer referenced by anyDRef(which can allow eagerly cleaning up associated memory, rather than letting the GC figure it out on its own). This will be used by Dagger to allow cleaning up cached Dagger task results once all user references are deleted, and the scheduler determines that it no longer needs to use that data. This can cause memory usage to be better controlled when Dagger (and MemPool) are tracking large amounts of data.