Treat empty quoted field as not empty sentinel for Strings #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #138. The biggest question I have is whether we should view this as a bugfix or a breaking change in behavior. I think it's arguable either way. As a note, this doesn't break anything in current CSV.jl code, which is maybe a signal that this change in behavior isn't super common or makes that much of a difference? cc: @nickrobinson251, @Drvi
Codecov ReportBase: 90.98% // Head: 90.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 9 9
Lines 1608 1608
=======================================
Hits 1463 1463
Misses 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nickrobinson251
approved these changes
Oct 20, 2022
Drvi
approved these changes
Oct 21, 2022
Co-authored-by: Nick Robinson <npr251@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #138.
The biggest question I have is whether we should view this as a bugfix or a breaking change in behavior. I think it's arguable either way.
As a note, this doesn't break anything in current CSV.jl code, which is maybe a signal that this change in behavior isn't super common or makes that much of a difference?
cc: @nickrobinson251, @Drvi