Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for groupmark validation #169

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fixes for groupmark validation #169

merged 1 commit into from
Jun 5, 2023

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Jun 3, 2023

fixes #168

@Drvi Drvi requested a review from quinnj June 3, 2023 09:35
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41c1bdd) 87.58% compared to head (1b5d26f) 87.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          10       10           
  Lines        1860     1861    +1     
=======================================
+ Hits         1629     1630    +1     
  Misses        231      231           
Impacted Files Coverage Δ
src/Parsers.jl 87.29% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LilithHafner
Copy link

Thank you! This looks like it fully and adequately addresses the issue.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Drvi! Especially love all the additional test cases here.

@quinnj quinnj merged commit dc4babc into main Jun 5, 2023
@quinnj quinnj deleted the td-groupmark-fixes branch June 5, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groupmark bugs
3 participants