Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rounding option #171

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Introduce rounding option #171

merged 2 commits into from
Jun 6, 2023

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Jun 5, 2023

This is useful for FixedDecimals, but it would also be useful when parsing DateTimes with nanosecond resolution, at least I always had to import them as strings, strip the last couple of digits, and parse again since which is just poor mans rounding. nothing, the default value for rounding, should mark the value as invalid if it cannot be represented exactly without rounding (do we need INEXACT code?)

Best paired with a Conf/TypeParser approach a la #131 because for some columns rounding might be acceptable but for others, it might not.

src/Parsers.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c142819) 88.49% compared to head (028e189) 88.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          10       10           
  Lines        1852     1852           
=======================================
  Hits         1639     1639           
  Misses        213      213           
Impacted Files Coverage Δ
src/Parsers.jl 87.29% <100.00%> (ø)
src/floats.jl 89.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit 4d4efcc into main Jun 6, 2023
@quinnj quinnj deleted the td-rounding-options branch June 6, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants