Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for
FixedDecimal
s, but it would also be useful when parsingDateTimes
with nanosecond resolution, at least I always had to import them as strings, strip the last couple of digits, and parse again since which is just poor mans rounding.nothing
, the default value forrounding
, should mark the value as invalid if it cannot be represented exactly without rounding (do we needINEXACT
code?)Best paired with a
Conf
/TypeParser
approach a la #131 because for some columns rounding might be acceptable but for others, it might not.