Introduce a beta AbstractConf type to allow custom types to avoid ove… #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-specializing I tried to implement the minimum possible here so we can let custom types start experimenting with this until we settle on the full API.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 88.41% 88.26% -0.16%
==========================================
Files 10 10
Lines 1865 1875 +10
==========================================
+ Hits 1649 1655 +6
- Misses 216 220 +4
☔ View full report in Codecov by Sentry. |
Drvi
approved these changes
Jun 13, 2023
Comment on lines
-353
to
+363
| @inline _xparse(::Type{T}, source::Union{AbstractVector{UInt8}, IO}, pos, len, options::Options=XOPTIONS, ::Type{S}=returntype(T)) where {T, S} = | ||
| _xparse(conf::AbstractConf{T}, source::Union{AbstractVector{UInt8}, IO}, pos, len, options::Options=XOPTIONS, ::Type{S}=returntype(T)) where {T, S} = |
There was a problem hiding this comment.
This was helpful for the FixedDecimal support, thanks! I wonder if we want to mark this as @noinline explicitly? I'm not sure what the rules for inlining are and if this changes back for whatever reason, compile times and binary size will probably be too much for FixedPointDecimals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r-specializing
I tried to implement the minimum possible here so we can let custom types start experimenting with this until we settle on the full API.