Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indexing #23

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fix indexing #23

merged 1 commit into from
Oct 1, 2018

Conversation

JackDunnNZ
Copy link
Contributor

No description provided.

@quinnj
Copy link
Member

quinnj commented Oct 1, 2018

Thanks for the PR! Did you have cases where you were hitting the non-generated code paths here? I'd be interested if so.

@JackDunnNZ
Copy link
Contributor Author

Nothing real, only when I ctrl-c'd in the middle of reading and it fell back to the non-generated path. Figured I may as well fix it :)

@quinnj
Copy link
Member

quinnj commented Oct 1, 2018

Cool; thanks!

@quinnj quinnj merged commit 763c900 into JuliaData:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackDunnNZ @quinnj