Fix inconsistency between row and column behavior of MatrixTable #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #261. Because `MatrixTable` subtypes `AbstractColumns`, it inherits certain behavior like `length`; but when it needs to fulfill the "rows" interface, it needs `length` to be defined in terms of the # of rows instead of the # of columns. We fix this inconsistency here by defining another type that mirrors `MatrixTable` but is used in the rows case.
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 94.72% 94.89% +0.17%
==========================================
Files 7 7
Lines 663 666 +3
==========================================
+ Hits 628 632 +4
+ Misses 35 34 -1
Continue to review full report at Codecov.
|
|
I understand one needs to call |
|
Correct; that was always the official API, but if you happened to just iterate |
bkamins
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261. Because
MatrixTablesubtypesAbstractColumns, itinherits certain behavior like
length; but when it needs to fulfillthe "rows" interface, it needs
lengthto be defined in terms of the #of rows instead of the # of columns. We fix this inconsistency here by
defining another type that mirrors
MatrixTablebut is used in the rowscase.