-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Julia versions before 1.0. #76
Drop support for Julia versions before 1.0. #76
Conversation
GunnarFarneback
commented
Mar 15, 2020
•
edited
Loading
edited
- Drop support for Julia versions before 1.0.
- Remove Compat dependency.
- Update Project.toml to allow auto-merge to General registry.
- Update Travis configuration.
- Replace Codecs dependency with Base64 stdlib.
- Bump version to 0.4.0.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 75.84% 75.72% -0.12%
==========================================
Files 12 12
Lines 1308 1306 -2
==========================================
- Hits 992 989 -3
- Misses 316 317 +1
Continue to review full report at Codecov.
|
Looks great, thanks for doing this! Only failure appears to be a minor loss of coverage, but I don't think that merits holding it up. I'm going to give until end of business today in the off chance anyone raises objections, then I'll merge this and do the manual tag mentioned in #73. |
That report is weird since it claims coverage changes in untouched files and that the total number of missed lines have increased despite a 100% coverage of the diff. But anyhow, if you make simplifications to covered code, the expected result is a loss of relative coverage. |
Yeah, I figured it was something like that. I'm not concerned :-) |
Coverage improved for Julia, which made coverge reports dropped because it got more accurate 😛 |
* Drop support for Julia versions before 1.0. * Update travis configuration. * Replace Codecs dependency with Base64 stdlib. Co-authored-by: Gunnar Farnebäck <gunnar.farneback@contextvision.se>
* Drop support for Julia versions before 1.0. * Update travis configuration. * Replace Codecs dependency with Base64 stdlib. Co-authored-by: Gunnar Farnebäck <gunnar.farneback@contextvision.se>