Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Julia versions before 1.0. #76

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

GunnarFarneback
Copy link
Contributor

@GunnarFarneback GunnarFarneback commented Mar 15, 2020

  • Drop support for Julia versions before 1.0.
  • Remove Compat dependency.
  • Update Project.toml to allow auto-merge to General registry.
  • Update Travis configuration.
  • Replace Codecs dependency with Base64 stdlib.
  • Bump version to 0.4.0.

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #76 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   75.84%   75.72%   -0.12%     
==========================================
  Files          12       12              
  Lines        1308     1306       -2     
==========================================
- Hits          992      989       -3     
- Misses        316      317       +1     
Impacted Files Coverage Δ
src/YAML.jl 28.00% <ø> (-5.34%) ⬇️
src/constructor.jl 73.42% <100.00%> (ø)
src/writer.jl 85.00% <0.00%> (-5.00%) ⬇️
src/scanner.jl 74.88% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f2194...b4297e6. Read the comment docs.

@kescobo
Copy link
Collaborator

kescobo commented Mar 16, 2020

Looks great, thanks for doing this! Only failure appears to be a minor loss of coverage, but I don't think that merits holding it up. I'm going to give until end of business today in the off chance anyone raises objections, then I'll merge this and do the manual tag mentioned in #73.

@GunnarFarneback
Copy link
Contributor Author

Only failure appears to be a minor loss of coverage,

That report is weird since it claims coverage changes in untouched files and that the total number of missed lines have increased despite a 100% coverage of the diff. But anyhow, if you make simplifications to covered code, the expected result is a loss of relative coverage.

@kescobo
Copy link
Collaborator

kescobo commented Mar 16, 2020

Yeah, I figured it was something like that. I'm not concerned :-)

@ChrisRackauckas
Copy link

Coverage improved for Julia, which made coverge reports dropped because it got more accurate 😛

@kescobo kescobo merged commit c61fd36 into JuliaData:master Mar 16, 2020
@GunnarFarneback GunnarFarneback deleted the drop_pre_julia_1_support branch March 17, 2020 07:55
@kescobo kescobo mentioned this pull request Mar 17, 2020
zbdekrak pushed a commit to zbdekrak/YAML.jl that referenced this pull request Apr 2, 2020
* Drop support for Julia versions before 1.0.

* Update travis configuration.

* Replace Codecs dependency with Base64 stdlib.

Co-authored-by: Gunnar Farnebäck <gunnar.farneback@contextvision.se>
zbdekrak pushed a commit to zbdekrak/YAML.jl that referenced this pull request Apr 2, 2020
* Drop support for Julia versions before 1.0.

* Update travis configuration.

* Replace Codecs dependency with Base64 stdlib.

Co-authored-by: Gunnar Farnebäck <gunnar.farneback@contextvision.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants