Make tests more modular #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethaxen
commented
Jan 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 79.51% 78.70% -0.81%
==========================================
Files 2 2
Lines 371 371
==========================================
- Hits 295 292 -3
- Misses 76 79 +3
Continue to review full report at Codecov.
|
frankschae
reviewed
Jan 10, 2022
|
Thanks @sethaxen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the tests to be more modular, which will make adding tests for additional backends more straightforward. Some notes:
included for testing a single componentisachecks in the test functions that special-cased for certain backends now are changed by keyword argumentstest_utils.jl.