Removes rules depending on casted #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Oct 17, 2019
| @@ -59,7 +59,7 @@ end | |||
|
|
|||
| function rrule(::typeof(sum), x) | |||
| function sum_pullback(ȳ) | |||
| return (NO_FIELDS, cast(ȳ)) | |||
| return (NO_FIELDS, @thunk(fill(ȳ, size(x)))) | |||
There was a problem hiding this comment.
should we consider using Fill from FillArrays instead of fill?
There was a problem hiding this comment.
That's definitely a thing we're going to do, but at a later date, just to avoid the added complexity for now (we don't want to have to deal with any FillArray-specific issues that aren't really ChainRules things for the time being)
| Δz = randn(rng) | ||
|
|
||
| frule_test(hypot, (x, Δx), (y, Δy)) | ||
| rrule_test(hypot, Δz, (x, x̄), (y, ȳ)) |
There was a problem hiding this comment.
if there a reason these use frule_test but the tests for e.g. atan2 call frule then test the output.
Is it because the atan2 tests pre-date frule_test?
There was a problem hiding this comment.
Is it because the atan2 tests pre-date frule_test?
I suspect that this is the case. Will open an issue and resolve at a later date.
willtebbutt
reviewed
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches to JuliaDiff/ChainRulesCore.jl#55
There is also a surprisingly large change to
hypot's testsas they were AFAWCT nonsense.