Gradient for dot(x,A,y) #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2020 00:42
willtebbutt
reviewed
Sep 4, 2020
Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
willtebbutt
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
I'm happy with this. @mcabbott if you could bump the patch version I would be happy to merge and to create a release. Thanks for the contribution!
|
Oops totally lost track of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like it says.
Can be made about 15% faster by using things like
lmul!(conj(dz), Ay)instead of broadcasting.