[WIP] Replace all uses of add and mul with + and * and define promotions etc #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ararslan
reviewed
May 28, 2019
| @@ -17,7 +17,7 @@ notifications: | |||
| # - julia -e 'Pkg.clone(pwd()); Pkg.build("ChainRules"); Pkg.test("ChainRules"; coverage=true)' | |||
| after_success: | |||
| # push coverage results to Coveralls | |||
| - julia -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())' | |||
| - julia -e 'using Pkg; Pkg.+(Coveralls.process_folder())' | |||
There was a problem hiding this comment.
Yes, I was ment to not commit that one
ararslan
reviewed
May 28, 2019
| const PRECEDENCE_LIST = [:wirtinger, :casted, :zero, :dne, :one, :thunk, :fallback] | ||
|
|
||
| global defs = Expr(:block) | ||
|
|
||
| let previous_add_name = :add, previous_mul_name = :mul | ||
| let previous_add_name = :(Base.:+), previous_mul_name = :(Base.:*) |
There was a problem hiding this comment.
This block here could likely be repurposed to define the method hierarchy that resolves ambiguities
This was referenced Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @ararslan #37 (comment)
This is going to require so much code.
I've just done the build find and replace so far,
next comes fixing all the ambiguities.
by rewriting a bunch of it to use promotion rules etc
And deleting redundant code after that