Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix atan2 rules #79

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Fix atan2 rules #79

merged 2 commits into from
Aug 9, 2019

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Aug 9, 2019 •
edited
Loading

@oxinabox
Copy link
Member

oxinabox commented Aug 9, 2019

Can you add tests based on Finite Differencing?
Helper functions are in test/test_utils.jl

@YingboMa
Copy link
Member Author

YingboMa commented Aug 9, 2019

Can I do that in a separate PR?

@oxinabox
Copy link
Member

oxinabox commented Aug 9, 2019

Sure.
I thought test_scalar did this. But it seems not.

We should change that.
And then use the improved @test_scalar here

@oxinabox
Copy link
Member

oxinabox commented Aug 9, 2019

I have checked this against Wikipedia. So I am satisfied.

@oxinabox oxinabox merged commit 62c448f into JuliaDiff:master Aug 9, 2019
@YingboMa YingboMa deleted the myb/atan branch August 9, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YingboMa @oxinabox