Use FiniteDifferences in tests #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 3 3
Lines 165 165
=======================================
Hits 160 160
Misses 5 5 Continue to review full report at Codecov.
|
|
Fixed by #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted this PR from #79, I guess this makes it easier to review.
This PR replaces the custom and very basic forward finite differencing method in the tests with FiniteDifferences (e.g. also used by ChainRulesTestUtils). This allows us to lower the tolerances quite significantly which hopefully uncovers incorrect implementations more reliably.