Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting a release #66

Open
ToucheSir opened this issue Jan 8, 2022 · 7 comments
Open

Cutting a release #66

ToucheSir opened this issue Jan 8, 2022 · 7 comments

Comments

@ToucheSir
Copy link

Even though Diffractor isn't yet feature complete, it can already be a major improvement over Zygote for real-world use cases.

@anhinga
Copy link

anhinga commented Jan 8, 2022 via email

@ToucheSir
Copy link
Author

Just to be clear, this is a question to the maintainers and not an announcement or guarantee of anything :)

@anhinga
Copy link

anhinga commented Jan 8, 2022 via email

@anhinga
Copy link

anhinga commented Jan 8, 2022

(lesson for me: not to reply via e-mail interface :-) )

@oxinabox
Copy link
Member

we should cut a 0.1.0 release.
So that not all changes are breaking.

Probably should do so as soon as CI is not failing?

@oxinabox oxinabox changed the title Cutting a 0.0.1 release Cutting a release Jan 11, 2022
@mcabbott
Copy link
Member

Not blocking, but should we make some effort to start organising a larger set of tests for this package?

Zygote's tests contain a lot of knowledge about potentially awkward edge cases, and it's possible that we should trawl through them and capture that. While hopefully leaving behind some of the very repetitive bits, or things which seem well captured by ChainRules's tests.

It has few second derivative tests, and maybe no forward mode tests, but the same awkward cases should ideally work for all of these. Perhaps we should structure things to make that easy, even if many fail right now.

@ChrisRackauckas
Copy link
Member

I think copying a lot of Zygote's tests would be a good idea, and just mark them broken if they don't work. That's something anyone interested in Diffractor can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants