Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to work on Julia master #107

Merged
merged 2 commits into from
Feb 14, 2023
Merged

updates to work on Julia master #107

merged 2 commits into from
Feb 14, 2023

Conversation

oscardssmith
Copy link
Member

JuliaLang/julia#48601 added a new VarState struct to represent undef static params.

@oscardssmith
Copy link
Member Author

@Keno can you reproduce the CI failure locally I can't, and can't figure out why CI and my computer are giving different results.

@codecov-commenter
Copy link

Codecov Report

Base: 50.87% // Head: 50.50% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (7c79ff6) compared to base (0241872).
Patch coverage: 15.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   50.87%   50.50%   -0.37%     
==========================================
  Files          27       27              
  Lines        2632     2651      +19     
==========================================
  Hits         1339     1339              
- Misses       1293     1312      +19     
Impacted Files Coverage Δ
src/codegen/forward_demand.jl 29.29% <0.00%> (-1.56%) ⬇️
src/tangent.jl 22.32% <0.00%> (-2.21%) ⬇️
src/stage1/recurse.jl 96.27% <75.00%> (-0.47%) ⬇️
src/stage1/forward.jl 66.66% <0.00%> (-3.34%) ⬇️
src/stage1/generated.jl 72.80% <0.00%> (-0.12%) ⬇️
src/extra_rules.jl 45.45% <0.00%> (+0.90%) ⬆️
src/stage2/interpreter.jl 22.72% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscardssmith oscardssmith merged commit 5b3a846 into main Feb 14, 2023
@oscardssmith oscardssmith deleted the use-VarState branch February 14, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants