-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Asciicast to regression tests #2376
Conversation
.github/workflows/Downstream.yml
Outdated
err isa Pkg.Resolve.ResolverError || rethrow() | ||
# If we can't resolve that means this is incompatible by SemVer and this is fine | ||
# It means we marked this as a breaking change, so we don't need to worry about | ||
# Mistakenly introducing a breaking change, as we have intentionally made one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this just encourages people to make breaking changes 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, I think you need something like this if you're going to put the workflow on 20+ repos, like SciML does (where I copied it from). Because it also could be some unrelated dependency has made a breaking change, and the package being tested has updated for it, but one of the regressionees has not, and then you can't resolve, so you can get failing CI unrelated to either package making a breaking release. (Although the comment is not focusing on that case, I suspect it can be common).
Agreed it's probably not necessary here though
Oops, missed that! Ok, I updated this PR to just add Asciicast there |
do we only want workflow-dispatch for regression-tests.yml? That seems OK if we remember to run it, but otherwise we could add it to just run every time |
I think we should at least attempt to be mindful of CI resources. I'm not overly fond of running the tests of a bunch of unrelated packages every time we fix a typo in Documenter. And if you're touching internals, Documenter is under no obligation to ensure you don't break. In general, I use the We also talked about adding a TODO item to the release checklist: |
I'd say let's stick to running this manually. Those tests are informational and not strictly part of the Documenter test suite.
I thought we already did, apparently not. We definitely should. |
bump |
Thank you! |
Based on https://github.com/SciML/SciMLBase.jl/blob/master/.github/workflows/Downstream.yml
Briefly discussed a few years ago here: #1675 (comment)
I've only added my new Asciicast.jl so far, but I imagine we could add all the documenter plugins, if there is interest