Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DynamicSumTypes to 2.0 #1050

Merged
merged 13 commits into from
Jun 23, 2024
Merged

Update DynamicSumTypes to 2.0 #1050

merged 13 commits into from
Jun 23, 2024

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Jun 22, 2024

Still need to release it

@Tortar Tortar marked this pull request as draft June 22, 2024 00:29
@Tortar Tortar marked this pull request as ready for review June 22, 2024 22:35
@Tortar Tortar requested a review from Datseris June 22, 2024 22:35
@Tortar
Copy link
Member Author

Tortar commented Jun 22, 2024

The only breaking change here is that it is needed to use @finalize_dispatch if one uses @multiagent in a package. There is no way to avoid that, the previous methodology was actually worse, see here for more explainations on why: https://discourse.julialang.org/t/is-using-base-delete-method-on-user-defined-functions-safe/115194

@Datseris
Copy link
Member

Merge and tag? This is done right?

@Tortar Tortar merged commit 051f62b into main Jun 23, 2024
6 checks passed
@Tortar Tortar deleted the Tortar-patch-1 branch June 23, 2024 17:01
@Tortar
Copy link
Member Author

Tortar commented Jun 23, 2024

yeah I tag now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Datseris Datseris Datseris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tortar @Datseris