-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish tutorial and matcher interface #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am presenting this tomorrow so I am merging it in. It would be fantastic to get tests for the new basin enclosure matcher @KalelR , but this can be done when you have some time. Would also be fantastic to have an Example with your kuramoto system that shows that using other matchers doesn't work as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the tutorial and also truly finishes the matcher interface. The interface is based on the
matching_map
function, which is a rename of thereplacement_map
function. See the docstring ofIDMatcher
andmatching_map
for the new interface.The PR adds a comparison also with BifurcationKit.jl.
In this PR I've also implemented the desired
MatchByBasinEnclosure
. It is part of the interface now so it is exported and added to the docs. I've also tested that it "runs" with the tutorial example. But, I have no good system at the moment to test it with. If I use the system of the tutorial, and after I match the normal way with the tutorial I try again by doing:then I get
notice how when we go into the first bistable regime there is something wonky (a black triangle is high in y axis), and when we go to the second bistable regime the attractor labels alternate all the time. I don't know if this is correct for this system because the basins are super duper fractal and thus everything all the time fluctuates a lot, or there is something wrong in my logic. In any case, I'd appreciate some help testing this new matcher.