This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Enhance flexibility of getting/setting model properties #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for type of `model.properties` and uses correct approach to update values
Switch `update_abm_parameters!` function name with `update_abm_properties!` because the function updates `model.properties` and not the `params` of the interactive application
Okay, I think it is about time we port |
Never used DrWatson before. I'll have a look if I can make it work. |
Sure, this is doable. I will implement three helper functions in Will push the changes to this PR here and rename it appropriately. |
fbanning
changed the title
Enable model.properties updates when using structs
Enhance flexibility of getting/setting model properties
Jul 29, 2021
Datseris
reviewed
Jul 29, 2021
Datseris
reviewed
Jul 29, 2021
fbanning
commented
Jul 29, 2021
Anything else you'd like me to incorporate into this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.