-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CoDaDistance based on Distances.jl. #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add tests and possibly implement some methods for result_type
as discussed.
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Before you start to add tests, you will need to add |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 76.52% 76.85% +0.32%
==========================================
Files 6 7 +1
Lines 213 216 +3
==========================================
+ Hits 163 166 +3
Misses 50 50
Continue to review full report at Codecov.
|
Awesome, please add a [compat] entry for Distances.jl in the Project.toml. Unfortunately the package manager doesn't add it by default so you have to activate the environment and type |
Awesome, we only need some tests now with the distance in action. For example, you can activate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!
No description provided.