Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CoDaDistance based on Distances.jl. #25

Merged
merged 13 commits into from
Sep 30, 2021

Conversation

mrr00b00t
Copy link
Contributor

No description provided.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests and possibly implement some methods for result_type as discussed.

src/distances.jl Outdated Show resolved Hide resolved
src/distances.jl Outdated Show resolved Hide resolved
src/distances.jl Outdated Show resolved Hide resolved
mrr00b00t and others added 4 commits September 30, 2021 13:21
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
src/CoDa.jl Outdated Show resolved Hide resolved
src/CoDa.jl Outdated Show resolved Hide resolved
src/distances.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Sep 30, 2021

Before you start to add tests, you will need to add Distances.jl to the Project.toml by activating the folder and typing ] add Distances.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #25 (0226a77) into master (8325cd5) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   76.52%   76.85%   +0.32%     
==========================================
  Files           6        7       +1     
  Lines         213      216       +3     
==========================================
+ Hits          163      166       +3     
  Misses         50       50              
Impacted Files Coverage Δ
src/distances.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8325cd5...0226a77. Read the comment docs.

src/CoDa.jl Outdated Show resolved Hide resolved
src/CoDa.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Sep 30, 2021

Awesome, please add a [compat] entry for Distances.jl in the Project.toml. Unfortunately the package manager doesn't add it by default so you have to activate the environment and type ] status to see the version of distances that is installed in your local version of CoDa.jl

Project.toml Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Sep 30, 2021

Awesome, we only need some tests now with the distance in action. For example, you can activate the test directory and add the Distances.jl package there as well as a test dependency. Load it in runtests.jl and create a new test file test/distances.jl with the pairwise for example.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@juliohm juliohm merged commit 81a18b4 into JuliaEarth:master Sep 30, 2021
@mrr00b00t mrr00b00t deleted the jose-issue-74 branch October 1, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants