Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @enum for GLFW constants #130

Open
3 of 5 tasks
jayschwa opened this issue Jan 9, 2018 · 0 comments
Open
3 of 5 tasks

Use @enum for GLFW constants #130

jayschwa opened this issue Jan 9, 2018 · 0 comments

Comments

@jayschwa
Copy link
Member

jayschwa commented Jan 9, 2018

ErrorCode is already an enum. It can be rolled out to more of the constants.

Candidates:

  • Key
  • Button actions (e.g. press, release)
  • Modifier keys
  • Cursors
  • Window hints
  • etc

The only downside is that exceptions might occur if Julia gets a value that isn't defined in the enum. This probably won't occur under normal circumstances since this package also controls which version of the GLFW library gets used. However, it might be good to write a little script that compares our enums to what is in glfw3.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant