Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adam with decay #130

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Adam with decay #130

merged 10 commits into from
Apr 11, 2024

Conversation

benedict-96
Copy link
Collaborator

Implements a version of the Adam optimizer where we have

$$\eta = \exp\left(log\left(\frac{\eta_2}{\eta_1}\right) / \mathtt{n\_epochs}\right)^t\eta_1$$

for the learning rate.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.31%. Comparing base (af93bf5) to head (d300189).
Report is 9 commits behind head on main.

Files Patch % Lines
...imizers/adam_optimizer_with_learning_rate_decay.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   62.53%   63.31%   +0.77%     
==========================================
  Files         111      114       +3     
  Lines        3222     3260      +38     
==========================================
+ Hits         2015     2064      +49     
+ Misses       1207     1196      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft April 10, 2024 15:57
@benedict-96 benedict-96 marked this pull request as ready for review April 10, 2024 17:31
@michakraus michakraus merged commit 88f903c into main Apr 11, 2024
13 of 16 checks passed
@michakraus michakraus deleted the adam_with_decay branch April 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants