Increase test coverage (by removing zombie files) and added struct DataLoader
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
===========================================
+ Coverage 49.08% 59.32% +10.24%
===========================================
Files 101 96 -5
Lines 2785 2358 -427
===========================================
+ Hits 1367 1399 +32
+ Misses 1418 959 -459
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved the folder
orthogonalization_proceduresfromsrctolegacy. This is because I'm not sure anymore if an implementation of symplectic Householder makes much sense (the "orthogonalization" is done on a non-compact set as opposed to regular Householder and is therefore very unstable). For symplectic autoencoders we are exclusively relying onPSDLayers now, which are much easier to train and generalize (almost) as well, so optimization on the symplectic Stiefel manifold is no longer required (only on the regular Stiefel manifold).I have also created a new struct
DataLoader, that for now only has a single constructor, but should eventually work with all our data formats (HDF5,GeometricEnsemble, etc). There's also a small test for it.