Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GPUArrays. #32

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Bump GPUArrays. #32

merged 4 commits into from
Jun 22, 2022

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 22, 2022

No description provided.

@maleadt maleadt marked this pull request as ready for review June 22, 2022 06:35
@maleadt
Copy link
Member Author

maleadt commented Jun 22, 2022

Looks like the == tests with missing break mapreduce.

@maleadt maleadt marked this pull request as draft June 22, 2022 07:17
@maleadt
Copy link
Member Author

maleadt commented Jun 22, 2022

Ah, this is just #26: The == implementation uses a Tuple{Bool,Bool} which is only 2 bytes.

@maleadt maleadt marked this pull request as ready for review June 22, 2022 09:42
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #32 (f97860b) into main (56f870c) will decrease coverage by 3.67%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   72.88%   69.20%   -3.68%     
==========================================
  Files          37       37              
  Lines        1169     1169              
==========================================
- Hits          852      809      -43     
- Misses        317      360      +43     
Impacted Files Coverage Δ
lib/core/argument_encoder.jl 0.00% <0.00%> (ø)
src/mapreduce.jl 100.00% <ø> (ø)
lib/core/error.jl 0.00% <0.00%> (-70.22%) ⬇️
src/utilities.jl 75.86% <0.00%> (-17.25%) ⬇️
lib/core/helpers.jl 35.71% <0.00%> (-7.15%) ⬇️
src/compiler/execution.jl 86.95% <0.00%> (-3.48%) ⬇️
lib/core/compile-opts.jl 84.21% <0.00%> (-2.64%) ⬇️
src/compiler/gpucompiler.jl 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ed840...f97860b. Read the comment docs.

@maleadt maleadt merged commit ddfc1e4 into main Jun 22, 2022
@maleadt maleadt deleted the tb/gpuarrays branch June 22, 2022 09:44
@alanedelman alanedelman mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant