avoid ReshapedArray using Int128 in metal kernel #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't notice that |
tgymnich
approved these changes
Jul 2, 2024
|
@tgymnich I update the code to handle older julia version. One failed test is because the GPUArrays test with |
|
@chengchingwen I also cannot reproduce the issue CI is having on 1.9. |
|
I've seen the 1.9 issue before. It's sporadic and unrelated. @chengchingwen can you submit a PR that links back to this PR to GPUArrays to unbreak the test? |
|
We should probably also submit a similar patch to oneAPI.jl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Base.ReshapedArrayis usingInt128for computing the indices withBase.MultiplicativeInverses._mul_high. This PR adds a device override to avoidInt128. Without this PR, the test will error out with "unsupported use of i128 value".fixes #332