-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for "LogExpFunctions" to "0.3" for package test #331
CompatHelper: bump compat for "LogExpFunctions" to "0.3" for package test #331
Conversation
b9ab5d1
to
1f5abee
Compare
…29-401-3166206896
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, same for this one, it doesn't run the tests with 0.3...
Also, needs a patch bump before merging. |
…29-401-3166206896
As in, we need to increase the patch version of KernelFunctions? why doesn't CompatHelper suggest that automatically as well... |
Yup, that would be nice. To be honest, I've actually not looked into whether that would be possible (I've just assumed that it's not). Will have a look now. |
Oh, it turns out that I have looked into this before: JuliaRegistries/CompatHelper.jl#132 |
…29-401-3166206896
…29-401-3166206896
I don't think we want a patch bump for compats in test |
Oh, sorry, you're totally right. |
any idea why it might not pull in LogExpFunctions=0.3? I can't see any conflicting dependencies that might hold it back.. |
StatsFuns is the culprit : https://github.com/JuliaStats/StatsFuns.jl/blob/master/Project.toml |
…29-401-3166206896
Let's try this again once #352 is in :) |
…29-401-3166206896
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now correctly pulling in LogExpFunctions=0.3
This pull request changes the compat entry for the
LogExpFunctions
package from0.2
to0.2, 0.3
for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.