Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "LogExpFunctions" to "0.3" for package test #331

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 8, 2021

This pull request changes the compat entry for the LogExpFunctions package from 0.2 to 0.2, 0.3 for package test.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@theogf theogf force-pushed the compathelper/new_version/2021-07-08-16-52-29-401-3166206896 branch from b9ab5d1 to 1f5abee Compare July 8, 2021 16:52
Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, same for this one, it doesn't run the tests with 0.3...

@willtebbutt
Copy link
Member

Also, needs a patch bump before merging.

@st--
Copy link
Member

st-- commented Jul 19, 2021

Also, needs a patch bump before merging.

As in, we need to increase the patch version of KernelFunctions? why doesn't CompatHelper suggest that automatically as well...

@willtebbutt
Copy link
Member

As in, we need to increase the patch version of KernelFunctions? why doesn't CompatHelper suggest that automatically as well...

Yup, that would be nice. To be honest, I've actually not looked into whether that would be possible (I've just assumed that it's not). Will have a look now.

@willtebbutt
Copy link
Member

Oh, it turns out that I have looked into this before: JuliaRegistries/CompatHelper.jl#132

@theogf
Copy link
Member

theogf commented Jul 21, 2021

I don't think we want a patch bump for compats in test

@willtebbutt
Copy link
Member

Oh, sorry, you're totally right.

@st--
Copy link
Member

st-- commented Jul 21, 2021

any idea why it might not pull in LogExpFunctions=0.3? I can't see any conflicting dependencies that might hold it back..

@theogf
Copy link
Member

theogf commented Jul 21, 2021

@st--
Copy link
Member

st-- commented Aug 10, 2021

Let's try this again once #352 is in :)

Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now correctly pulling in LogExpFunctions=0.3

@st-- st-- merged commit 83203aa into master Aug 11, 2021
@st-- st-- deleted the compathelper/new_version/2021-07-08-16-52-29-401-3166206896 branch August 11, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants