Factor out primitives and types to GeometryOpsCore.jl
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically guts the `types.jl` and `primitives.jl` files from GeometryOps and puts them into a new, low-dependency module that other packages can utilize for a convenient structure.
The name `Manifold` is up for debate, I just wanted some supertype for dispatch constraints.
rafaqz
approved these changes
Oct 2, 2024
asinghvi17
changed the title
GeometryOpsCore.jlGeometryOpsCore.jl
|
Will merge if docs build correctly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new GeometryOpsCore.jl package that other packages can depend on so we have a common core of types and frameworks throughout the ecosystem.
cc @rafaqz
This is still VERY WIP, we may choose to put more functionality in (I do want table support for flatten etc) or take functionality out.
Ideally, this goes out as a first draft in the next few days so it can be registered in the General registry.
This will enable the
cellarea(Spherical())idea for rafaqz/Rasters.jl#768.