Generic write from GeoInterface compatible geometries
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugs: 1. Incomplete PolylineM writers 2. Misshandling of missing in `get_mrange`, main writting block 3. Missed Multipatch type for no M-values 4. Incorrect bytes information for record length
evetion
requested changes
Dec 13, 2022
|
Maybe add a test for a simple table with a geometry column, to also test that code path (most commonly use case?) |
evetion
reviewed
Dec 13, 2022
|
Thanks! already pushed the |
|
Thanks for the comments I think that's a big improvement. It should be good to go, I have to sleep but feel free to merge if you are ok with it now. Edit: merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rehash of #34, but working with any GeoInterface.jl geometries, lazily.
I feel that Shapefile.jl should cover the spaces that GDAL fails, which is reading and writing very large datasets quickly.
(You could probably write a larger than-memory mmaped GeoJSON.jl file to a shapefile with this, if you only had 2GB RAM and sanity didn't prevail first)
Any stress testing and feedback would be good at this stage.
Note: there is a bunch of seemingly unrelated new code/changes for
This just made writing the PR easier.