-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rotations.jl for rotations #415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 93.81% 93.85% +0.04%
==========================================
Files 121 120 -1
Lines 3522 3501 -21
==========================================
- Hits 3304 3286 -18
+ Misses 218 215 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looking forward to these improvements @hyrodium ❤️ It would be nice if you could summarize the new types from Rotations.jl that replace the old types from ReferenceFrameRotations.jl in a comment here when you are done 👌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready to review! I added some comments for the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely PR @hyrodium , it is almost ready.
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@hyrodium I am available today in case you want to finish this PR for a final review. Thanks again for the great improvement. |
@hyrodium can you please rebase this PR on top of the latest master branch? |
@hyrodium any chance we could get this merged this week? We are planning a new breaking release and it would be nice to incorporate the changes here. |
Sorry for being late. I have merged the current |
I will update this PR in a few days to reflect the review comments. |
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Thank you @hyrodium ! ❤️ |
This PR fixes #344.
I'm keeping this PR as a draft because removing
ReferenceFrameRotations.DCM
is not finished yet.I just would like to share the progress and get some feedback on the changes on this PR.