Skip to content

Commit

Permalink
Add support for Observables v0.3 to the v0.5 release series. (#34)
Browse files Browse the repository at this point in the history
  • Loading branch information
@fredrikekre
fredrikekre committed Feb 26, 2020
1 parent 4939116 commit 8aecd2c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "JSExpr"
uuid = "97c1335a-c9c5-57fe-bc5d-ec35cebe8660"
license = "MIT"
version = "0.5.1"
version = "0.5.2"

[deps]
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Expand All @@ -10,9 +10,9 @@ Observables = "510215fc-4207-5dde-b226-833fc4488ee2"
WebIO = "0f1e0344-ec1d-5b48-a673-e5cf874b6c29"

[compat]
julia = "0.7, 1"
Observables = "0.2.2"
Observables = "0.2.2,0.3"
WebIO = "0.8.5"
julia = "0.7, 1"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
8 changes: 4 additions & 4 deletions test/runtests.jl
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using JSExpr
using WebIO
import WebIO: scopeid
import WebIO: scopeid, obsid
using Test

@testset "@js_str" begin
Expand Down Expand Up @@ -76,9 +76,9 @@ end
@test_throws ErrorException @js $ob

ob = Observable{Any}(w, "test", nothing)
@test @js($ob) == js"{\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":\"ob_02\",\"type\":\"observable\"}"
@test @js($ob) == js"{\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":$(obsid(ob)),\"type\":\"observable\"}"

@test @js($ob[]) == js"WebIO.getval({\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":\"ob_02\",\"type\":\"observable\"})"
@test @js($ob[] = 1) == js"WebIO.setval({\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":\"ob_02\",\"type\":\"observable\"},1)"
@test @js($ob[]) == js"WebIO.getval({\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":$(obsid(ob)),\"type\":\"observable\"})"
@test @js($ob[] = 1) == js"WebIO.setval({\"name\":\"test\",\"scope\":$(scopeid(w)),\"id\":$(obsid(ob)),\"type\":\"observable\"},1)"
end
end

14 comments on commit 8aecd2c

@twavv
Copy link
Member

@twavv twavv commented on 8aecd2c Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Unexpected error in registration

@twavv
Copy link
Member

@twavv twavv commented on 8aecd2c Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Unexpected error in registration

@fredrikekre
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again? I saw other package having problems some days ago too, but worked now.

@twavv
Copy link
Member

@twavv twavv commented on 8aecd2c Feb 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Unexpected error in registration

@fredrikekre
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again? :)

@twavv
Copy link
Member

@twavv twavv commented on 8aecd2c Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredrikekre I added you as an admin to JSExpr.jl, feel free to try to get it to work. :^)

@fredrikekre
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Unexpected error in registration

@fredrikekre
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/11423

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.2 -m "<description of version>" 8aecd2cd6f0fd415e61cce1ba395f3d11b234b07
git push origin v0.5.2

@fredrikekre
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Will fail due to missing compat on JSON, just making sure registrator is deployed.)

Please sign in to comment.