Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MSC & find_maximum_chroma robust to implementations of conversions #492

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

kimikage
Copy link
Collaborator

This reduces the hard-coded constants.
This also avoids unnecessary gamma correction in the out-of-gamut checking.

A part of this has been separated from PR #482.

…rsions

This reduces the hard-coded constants.
This also avoids unnecessary gamma correction in the out-of-gamut checking.
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #492 (f102e3f) into master (500297c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   93.12%   93.16%   +0.03%     
==========================================
  Files           9        9              
  Lines        1018     1009       -9     
==========================================
- Hits          948      940       -8     
+ Misses         70       69       -1     
Impacted Files Coverage Δ
src/algorithms.jl 61.32% <100.00%> (-2.79%) ⬇️
src/conversions.jl 99.68% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500297c...f102e3f. Read the comment docs.

@kimikage kimikage merged commit 8f6550d into JuliaGraphics:master Jun 20, 2021
@kimikage kimikage deleted the robust_msc branch June 20, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant