Add tests #8
Merged
Add tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Apr 12, 2017
| if VERSION >= v"0.6.0-dev.1015" | ||
| import Base.Iterators: drop | ||
| end | ||
| import Compat.Iterators: drop |
There was a problem hiding this comment.
need a higher min Compat version for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few things. First, it cleans up some of the version conditional logic in the internals, which is no longer necessary since this package now requires Julia 0.5 at a minimum. It also uses concrete types for array element types when those types are known (primarily
AbstractString->String). Next, status badges and a hat tip to dcjones. And finally, tests!Fixes #5