Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export some interface methods using GI, define GErrorException #46

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

jwahlstrand
Copy link
Member

No description provided.

…ce as instance argument

Saves having to type the interface name. Mainly useful in the getter/setter methods.
it's nice to be able to distinguish GError throws, which tend to be recoverable,
from things like MethodError
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (043eb29) 84.44% compared to head (239db6e) 84.51%.

Files Patch % Lines
GI/src/giimport.jl 97.22% 1 Missing ⚠️
src/GLib/gerror.jl 80.00% 1 Missing ⚠️
src/base.jl 0.00% 1 Missing ⚠️
src/events.jl 0.00% 1 Missing ⚠️
src/windows.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   84.44%   84.51%   +0.07%     
==========================================
  Files          43       44       +1     
  Lines        4608     4637      +29     
==========================================
+ Hits         3891     3919      +28     
- Misses        717      718       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwahlstrand jwahlstrand merged commit d9003dc into main Nov 25, 2023
11 checks passed
@jwahlstrand jwahlstrand deleted the jw/interface_methods2 branch November 25, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants