Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented theta function #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mivanovska007
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.00%. Comparing base (75204b4) to head (f4aa540).

Current head f4aa540 differs from pull request most recent head 5348405

Please upload reports for the commit 5348405 to get more accurate results.

Files Patch % Lines
src/cartesian.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   83.96%   75.00%   -8.97%     
==========================================
  Files           3        3              
  Lines         131      108      -23     
==========================================
- Hits          110       81      -29     
- Misses         21       27       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf
Copy link
Member

Moelf commented Jun 8, 2022

one thing I realized is that, delta theta is ambiguous, it can mean one of the two things:

  1. delta theta like delta eta, which is what we have in this PR -- you take thetas of the two 4-vectors, and you can take the diff between those two thetas
  2. delta theta like delta R, which is what we used in our offline discussion, this is the opening angle (not just in theta direction) between two 4-vectors

I think it might be wise to use the second definition instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants