reduce number of read during ROOTFile and basket unpacking, use more async, add remote (HTTP) source,
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 92.33% 91.26% -1.08%
==========================================
Files 10 11 +1
Lines 1436 1523 +87
==========================================
+ Hits 1326 1390 +64
- Misses 110 133 +23
Continue to review full report at Codecov.
|
Moelf
force-pushed
the
reduce_read_and_use_async
branch
from
c6cdb7b
to
21690fe
Compare
Moelf
changed the title
ROOTFile and basket unpacking, use more async, add remote (HTTP) source,
|
I promise I will fix code coverage later. |
|
Awesome 👏 😃 |
Moelf
added a commit
to Moelf/UnROOT.jl
that referenced
this pull request
Jun 23, 2022
…e async, add remote (HTTP) source, (JuliaHEP#154) * reduce basket reading io from 4 -> 1 * use more OffsetBuffer when appropriate * bump compatibility * add HTTP source support * Mmap based local file * async chunking * better error * 100% lock-free * scitoken ready * faster display branch * backport upgrade
Moelf
added a commit
to aminnj/UnROOT.jl
that referenced
this pull request
Jun 23, 2022
…e async, add remote (HTTP) source, (JuliaHEP#154) * reduce basket reading io from 4 -> 1 * use more OffsetBuffer when appropriate * bump compatibility * add HTTP source support * Mmap based local file * async chunking * better error * 100% lock-free * scitoken ready * faster display branch * backport upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything in #150 except the
xrootdgo_jllwhich is >= 1.6 only. I want to push all generic optimizations before finally adding the Go binding.