Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows id -u #158

Merged
merged 4 commits into from
Apr 5, 2022
Merged

fix windows id -u #158

merged 4 commits into from
Apr 5, 2022

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Apr 5, 2022

closes #157

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #158 (5a19f1a) into master (7499f9e) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   91.12%   91.18%   +0.05%     
==========================================
  Files          11       11              
  Lines        1487     1531      +44     
==========================================
+ Hits         1355     1396      +41     
- Misses        132      135       +3     
Impacted Files Coverage Δ
src/UnROOT.jl 90.00% <ø> (+4.28%) ⬆️
src/streamsource.jl 81.15% <50.00%> (-1.10%) ⬇️
src/iteration.jl 88.94% <0.00%> (-0.73%) ⬇️
src/streamers.jl 91.52% <0.00%> (-0.09%) ⬇️
src/custom.jl 98.71% <0.00%> (+0.03%) ⬆️
src/bootstrap.jl 93.09% <0.00%> (+0.11%) ⬆️
src/types.jl 94.18% <0.00%> (+0.13%) ⬆️
src/root.jl 93.72% <0.00%> (+0.18%) ⬆️
src/io.jl 89.39% <0.00%> (+0.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7499f9e...5a19f1a. Read the comment docs.

@Moelf Moelf merged commit c9f9143 into JuliaHEP:master Apr 5, 2022
@Moelf Moelf deleted the fix_windows_id branch April 5, 2022 17:34
Moelf added a commit to Moelf/UnROOT.jl that referenced this pull request Jun 23, 2022
* fix windows `id -u`

* remove hacky precompile

* fix CI
Moelf added a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
* fix windows `id -u`

* remove hacky precompile

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on Windows
2 participants