Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle [var][fix] style doubly jagged branch #188

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Oct 10, 2022

fix #187

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 90.19% // Head: 90.27% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (d827ebc) compared to base (232e85b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d827ebc differs from pull request most recent head 8071166. Consider uploading reports for the commit 8071166 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   90.19%   90.27%   +0.07%     
==========================================
  Files          11       11              
  Lines        1612     1625      +13     
==========================================
+ Hits         1454     1467      +13     
  Misses        158      158              
Impacted Files Coverage Δ
src/custom.jl 97.97% <100.00%> (+0.10%) ⬆️
src/root.jl 94.23% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Moelf Moelf merged commit 8b16c8f into master Oct 10, 2022
@Moelf Moelf deleted the handle_varfix_style_doubly_jagged branch October 10, 2022 19:04
Moelf added a commit to Moelf/UnROOT.jl that referenced this pull request Oct 10, 2022
* handle [var][fix] style doubly jagged branch

* fix tests for 1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable sized multidimensional array in ROOT file is partially read
1 participant