-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iterator interface fix #6 #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 81.58% 81.50% -0.08%
==========================================
Files 8 9 +1
Lines 885 930 +45
==========================================
+ Hits 722 758 +36
- Misses 163 172 +9
Continue to review full report at Codecov.
|
@aminnj mentioned that when iterating over a (wide) tree, one should be lazy about unpacking baskets because there could be a We don't have a tree iterator interface yet and this current design is hard to fit the bill, any suggestion would be welcomed. |
Co-authored-by: Nick Amin <namin@physics.ucsb.edu>
Looks very good! |
[skip ci]
The code is a bit messy but the idea is there. I will clean up a bit before merging just want to know if people have thoughts on the implementation. The speed seems okay, allocation probably can be reduced, but a revamp on the
interped_data()
would benefit all use case.It's thread-safe to iterator through multiple branches by simply zipping them together: